Add std::filesystem::path methods variant

CMakeLists.txt

@@ -16,7 +16,7 @@ option(BUILD_SHARED_LIBS "Build using shared libraries" ON)
 option(USE_BUNDLED_LIBS "Use bundled LZ4 PugiXML and Zlib. You can still exclude some" ON)
 cmake_dependent_option(USE_BUNDLED_LZ4 "Use bundled LZ4" ON "USE_BUNDLED_LIBS" OFF)
 cmake_dependent_option(USE_BUNDLED_PUGIXML "Use bundled PugiXML" ON "USE_BUNDLED_LIBS" OFF)
-cmake_dependent_option(USE_BUNDLED_ZLIB "Use bundled Zlib" ON "USE_BUNDLED_LIBS" OFF)
+cmake_dependent_option(USE_BUNDLED_ZLIB "Use bundled Zlib" OFF "USE_BUNDLED_LIBS" OFF)
 
 find_package(PkgConfig)
 

libxisf.cpp

@@ -17,21 +17,21 @@
  ************************************************************************/
 
 #include "libxisf.h"
-#include <unordered_map>
-#include <unordered_set>
-#include <cstring>
-#include <iostream>
-#include <sstream>
-#include <cstdlib>
+#include "streambuffer.h"
 #include <cmath>
+#include <cstdlib>
+#include <cstring>
+#include <fstream>
+#include <iostream>
 #include <lz4.h>
 #include <lz4hc.h>
 #include <pugixml.hpp>
+#include <sstream>
+#include <unordered_map>
 #include <zlib.h>
 #ifdef HAVE_ZSTD
 #include <zstd.h>
 #endif
-#include "streambuffer.h"
 
 namespace LibXISF
 {
@@ -701,6 +701,7 @@ public:
     void open(const ByteArray &data);
     /** Open image from istream. This method takes ownership of *io pointer */
     void open(std::istream *io);
+    void open(const std::filesystem::path &path);
     /** Close opended file release all data. */
     void close();
     /** Return number of images inside file */
@@ -754,6 +755,14 @@ void XISFReaderPrivate::open(std::istream *io)
     readXISFHeader();
 }
 
+void XISFReaderPrivate::open(const std::filesystem::path &path)
+{
+    close();
+    _io = std::make_unique<std::ifstream>(path, std::ios_base::in | std::ios_base::binary);
+    readSignature();
+    readXISFHeader();
+}
+
 void XISFReaderPrivate::close()
 {
     _io.reset();
@@ -1032,13 +1041,14 @@ public:
     void save(const String &name);
     void save(ByteArray &data);
     void save(std::ostream &io);
+    void save(const std::filesystem::path &path);
     void writeImage(const Image &image);
     static void writeFITSKeyword(pugi::xml_node &node, const FITSKeyword &keyword);
+    static void writePropertyElement(pugi::xml_node &node, const Property &property);
 private:
     void writeHeader();
     void writeImageElement(pugi::xml_node &node, const Image &image);
     void writeDataBlockAttributes(pugi::xml_node &image_node, const DataBlock &dataBlock);
-    void writePropertyElement(pugi::xml_node &node, const Property &property);
     void writeMetadata(pugi::xml_node &node);
     void updateImageAttachmentPos(pugi::xml_node &root, size_t offset);
     ByteArray _xisfHeader;
@@ -1084,6 +1094,16 @@ void XISFWriterPrivate::save(std::ostream &io)
     }
 }
 
+void XISFWriterPrivate::save(const std::filesystem::path &path)
+{
+    std::ofstream fw(path, std::ios_base::out | std::ios_base::binary);
+
+    if(fw.fail())
+        throw Error("Failed to open file");
+
+    save(fw);
+}
+
 void XISFWriterPrivate::writeImage(const Image &image)
 {
     _images.push_back(image);
@@ -1304,6 +1324,11 @@ void XISFReader::open(std::istream *io)
     p->open(io);
 }
 
+void XISFReader::open(const std::filesystem::path &path)
+{
+    p->open(path);
+}
+
 void XISFReader::close()
 {
     p->close();
@@ -1349,6 +1374,11 @@ void XISFWriter::save(std::ostream &io)
     p->save(io);
 }
 
+void XISFWriter::save(const std::filesystem::path &path)
+{
+    p->save(path);
+}
+
 void XISFWriter::writeImage(const Image &image)
 {
     p->writeImage(image);
@@ -1361,16 +1391,19 @@ public:
     void open(const ByteArray &data);
     /** Open image from istream. This method takes ownership of *io pointer */
     void open(std::istream *io);
+    void open(const std::filesystem::path &path);
     /** Close opended file release all data. */
     void close();
 
     void save(const String &name);
     void save(ByteArray &data);
     void save(std::ostream &io);
+    void save(const std::filesystem::path &path);
 
     void addFITSKeyword(uint32_t image, const FITSKeyword &keyword);
     void updateFITSKeyword(uint32_t image, const FITSKeyword &keyword, bool add);
     void removeFITSKeyword(uint32_t image, const String &name);
+    void updateProperty(uint32_t image, const Property &property);
 private:
     void readXISFHeader();
     void parseAttachmentPos(pugi::xml_node &root);
@@ -1382,7 +1415,6 @@ private:
     pugi::xml_document _doc;
     pugi::xml_node _root;
     std::map<int, std::pair<uint64_t, uint64_t>> _attachmentPos;// pair contain position and size
-    std::map<int, std::pair<uint64_t, uint64_t>> _attachmentPosNew;
 };
 
 
@@ -1408,6 +1440,13 @@ void XISFModifyPrivate::open(std::istream *io)
     readXISFHeader();
 }
 
+void XISFModifyPrivate::open(const std::filesystem::path &path)
+{
+    close();
+    _io = std::make_unique<std::ifstream>(path, std::ios_base::in | std::ios_base::binary);
+    readXISFHeader();
+}
+
 void XISFModifyPrivate::close()
 {
     _io.reset();
@@ -1445,6 +1484,8 @@ void XISFModifyPrivate::save(std::ostream &io)
     doc.append_child(pugi::node_comment).set_value("\nExtensible Image Serialization Format - XISF version 1.0\nCreated with libXISF - https://nouspiro.space\n");
     pugi::xml_node root_copy = doc.append_copy(_root);
 
+    parseAttachmentPos(_root);
+
     uint32_t size = 0;
     std::string header;
     while(true)
@@ -1485,6 +1526,16 @@ void XISFModifyPrivate::save(std::ostream &io)
     }
 }
 
+void XISFModifyPrivate::save(const std::filesystem::path &path)
+{
+    std::ofstream fw(path, std::ios_base::out | std::ios_base::binary);
+
+    if(fw.fail())
+        throw Error("Failed to open file");
+
+    save(fw);
+}
+
 void XISFModifyPrivate::addFITSKeyword(uint32_t image, const FITSKeyword &keyword)
 {
     if(!_root)
@@ -1551,6 +1602,27 @@ void XISFModifyPrivate::removeFITSKeyword(uint32_t image, const String &name)
         imageNode.remove_child(keywordNode);
 }
 
+void XISFModifyPrivate::updateProperty(uint32_t image, const Property &property)
+{
+    if(!_root)
+        throw Error("No input file opened");
+
+    pugi::xpath_node_set images = _root.select_nodes("//Image");
+
+    if(image >= images.size())
+        throw Error("Out of bounds");
+
+    pugi::xpath_variable_set variables;
+    variables.set("id", property.id.c_str());
+    pugi::xml_node imageNode = images[image].node();
+    pugi::xml_node propertyNode = imageNode.select_node("Property[@id=string($id)]", &variables).node();
+
+    if(propertyNode)
+        imageNode.remove_child(propertyNode);
+
+    XISFWriterPrivate::writePropertyElement(imageNode, property);
+}
+
 void XISFModifyPrivate::readXISFHeader()
 {
     char signature[8];
@@ -1579,6 +1651,7 @@ void XISFModifyPrivate::readXISFHeader()
 
 void XISFModifyPrivate::parseAttachmentPos(pugi::xml_node &root)
 {
+    _attachmentPos.clear();
     pugi::xpath_node_set locationAttributes = root.select_nodes("//@location");
     int i = 0;
     for(auto &attr : locationAttributes)
@@ -1603,7 +1676,6 @@ void XISFModifyPrivate::updateAttachmentPos(pugi::xml_node &root, size_t offset)
         pugi::xml_attribute attr = locationAttributes[pos.first].attribute();
         uint64_t attachmentSize = pos.second.second;
         std::string locationStr = "attachment:" + std::to_string(offset) + ":" + std::to_string(attachmentSize);
-        _attachmentPosNew[pos.first] = pos.second;
         offset += attachmentSize;
         attr.set_value(locationStr.c_str());
     }
@@ -1634,6 +1706,11 @@ void XISFModify::open(std::istream *io)
     p->open(io);
 }
 
+void XISFModify::open(const std::filesystem::path &path)
+{
+    p->open(path);
+}
+
 void XISFModify::close()
 {
     p->close();
@@ -1654,6 +1731,11 @@ void XISFModify::save(std::ostream &io)
     p->save(io);
 }
 
+void XISFModify::save(const std::filesystem::path &path)
+{
+    p->save(path);
+}
+
 void XISFModify::addFITSKeyword(uint32_t image, const FITSKeyword &keyword)
 {
     p->addFITSKeyword(image, keyword);
@@ -1669,6 +1751,11 @@ void XISFModify::removeFITSKeyword(uint32_t image, const String &name)
     p->removeFITSKeyword(image, name);
 }
 
+void XISFModify::updateProperty(uint32_t image, const Property &property)
+{
+    p->updateProperty(image, property);
+}
+
 #define STRING_ENUM(map, map2, c, e) { map.insert({#e, c::e}); map2.insert({c::e, #e}); }
 
 struct Init

libxisf.h

@@ -20,15 +20,15 @@
 #define LIBXISF_H
 
 #include "libXISF_global.h"
-#include <memory>
-#include <map>
-#include <variant>
-#include <fstream>
-#include <cstring>
-#include <vector>
 #include <cstdint>
-#include <memory>
+#include <cstring>
 #include <ctime>
+#include <filesystem>
+#include <map>
+#include <memory>
+#include <memory>
+#include <variant>
+#include <vector>
 
 namespace LibXISF
 {
@@ -370,6 +370,7 @@ public:
     void open(const ByteArray &data);
     /** Open image from istream. This method takes ownership of *io pointer */
     void open(std::istream *io);
+    void open(const std::filesystem::path &path);
     /** Close opended file release all data. */
     void close();
     /** Return number of images inside file */
@@ -396,6 +397,7 @@ public:
     void save(const String &name);
     void save(ByteArray &data);
     void save(std::ostream &io);
+    void save(const std::filesystem::path &path);
     void writeImage(const Image &image);
 private:
     XISFWriterPrivate *p;
@@ -419,10 +421,12 @@ public:
     void open(const String &name);
     void open(const ByteArray &data);
     void open(std::istream *io);
+    void open(const std::filesystem::path &path);
     void close();
     void save(const String &name);
     void save(ByteArray &data);
     void save(std::ostream &io);
+    void save(const std::filesystem::path &path);
 
     /**
      * @brief addFITSKeyword append new keyword to image
@@ -443,6 +447,12 @@ public:
      * @param name of keyword that will be removed
      */
     void removeFITSKeyword(uint32_t image, const String &name);
+    /**
+     * @brief updateProperty add new or update existing XISF Property
+     * @param image index of image to update
+     * @param property new value of property
+     */
+    void updateProperty(uint32_t image, const Property &property);
 private:
     XISFModifyPrivate *p;
 };

test/main.cpp

@@ -102,7 +102,7 @@ int main(int argc, char **argv)
         else
         {
             LibXISF::XISFReader reader;
-            reader.open(argv[1]);
+            reader.open(LibXISF::String(argv[1]));
             TEST(reader.imagesCount() != 1, "No image");
 
             const LibXISF::Image &image = reader.getImage(0);

variant.cpp

@@ -17,7 +17,6 @@
  ************************************************************************/
 
 #include <charconv>
-#include <type_traits>
 #include <map>
 #include <regex>
 #include <iomanip>
@@ -403,7 +402,6 @@ Variant variantFromString(Variant::Type type, const String &str)
 
 Variant::Type Variant::type() const
 {
-    int idx = _value.index();
     return (Variant::Type)_value.index();
 }
 
@@ -442,7 +440,7 @@ String Variant::toString() const
             ss << "{";
             for(int o=0; o<matrix.cols(); o++)
             {
-#if __GNUC__ >= 11 || __clang__
+#if __GNUC__ >= 11 || __clang_major__ >= 15
                 char str[128] = {0};
                 char *end = str + sizeof(str);
                 std::to_chars(str, end, matrix(i, o));