Add missing PUBLIC keyword and change LIBXISF_STATIC_LIB define

CMakeLists.txt

@@ -12,7 +12,9 @@ set(CMAKE_CXX_STANDARD_REQUIRED ON)
 find_package(QT NAMES Qt6 Qt5 COMPONENTS Core REQUIRED)
 find_package(Qt${QT_VERSION_MAJOR} COMPONENTS Core REQUIRED)
 
-add_library(XISF SHARED
+option(BUILD_SHARED_LIBS "Build using shared libraries" ON)
+
+add_library(XISF
   libXISF_global.h
   libxisf.cpp
   libxisf.h
@@ -26,7 +28,11 @@ set_target_properties(XISF PROPERTIES VERSION ${PROJECT_VERSION} SOVERSION ${PRO
 
 target_link_libraries(XISF PUBLIC Qt${QT_VERSION_MAJOR}::Core)
 
-target_compile_definitions(XISF PRIVATE LIBXISF_LIBRARY)
+if(BUILD_SHARED_LIBS)
+    target_compile_definitions(XISF PRIVATE LIBXISF_LIBRARY)
+else(BUILD_SHARED_LIBS)
+    target_compile_definitions(XISF PUBLIC LIBXISF_STATIC_LIB)
+endif(BUILD_SHARED_LIBS)
 
 set(XISF_PUBLIC_HEADERS libxisf.h libXISF_global.h)
 

debian/changelog

@@ -1,4 +1,4 @@
-libxisf (0.1.2-ubuntu1) UNRELEASED; urgency=medium
+libxisf (0.1.2-ubuntu1) focal; urgency=medium
 
   * Add qtbase5-dev as dependency to libxisf-dev
 

debian/control

@@ -14,7 +14,7 @@ Package: libxisf-dev
 Section: libdevel
 Architecture: any
 Multi-Arch: same
-Depends: libxisf qtbase5-dev (= ${binary:Version}), ${misc:Depends}
+Depends: libxisf (= ${binary:Version}), ${misc:Depends}, qtbase5-dev
 Description: Library to load and save XISF images
  Native format of PixInsight astroprocessing suite
 

libXISF_global.h

@@ -21,10 +21,14 @@
 
 #include <QtCore/qglobal.h>
 
-#if defined(LIBXISF_LIBRARY)
+#ifdef LIBXISF_STATIC_LIB
-#  define LIBXISF_EXPORT Q_DECL_EXPORT
+#  define LIBXISF_EXPORT
 #else
-#  define LIBXISF_EXPORT Q_DECL_IMPORT
+#  if defined(LIBXISF_LIBRARY)
+#    define LIBXISF_EXPORT Q_DECL_EXPORT
+#  else
+#    define LIBXISF_EXPORT Q_DECL_IMPORT
+#  endif
 #endif
 
 #endif // LIBXISF_GLOBAL_H