Deffered SQL query when database is visible

CMakeLists.txt

@@ -17,7 +17,7 @@ if(SANITIZE_ADDRESS_LEAK)
     set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -fsanitize=address -fsanitize=leak")
 endif(SANITIZE_ADDRESS_LEAK)
 
-find_package(Qt6 COMPONENTS Widgets Sql OpenGLWidgets Qml Charts REQUIRED)
+find_package(Qt6 COMPONENTS Widgets Sql OpenGLWidgets Qml Charts Svg REQUIRED)
 find_library(EXIF_LIB exif REQUIRED)
 find_library(FITS_LIB cfitsio REQUIRED)
 find_library(RAW_LIB NAMES raw_r REQUIRED)
@@ -105,7 +105,7 @@ if(STELLARSOLVER_INCLUDE AND STELLARSOLVER_LIB)
     message(STATUS "Found stellarsolver ${STELLARSOLVER_INCLUDE} ${STELLARSOLVER_LIB}")
 endif(STELLARSOLVER_INCLUDE AND STELLARSOLVER_LIB)
 
-target_link_libraries(tenmon PRIVATE Qt6::Widgets Qt6::Sql Qt6::OpenGLWidgets Qt6::Qml Qt6::Charts ${EXIF_LIB} ${FITS_LIB} ${RAW_LIB} ${WCS_LIB} ${LCMS2_LIB} XISF)
+target_link_libraries(tenmon PRIVATE Qt6::Widgets Qt6::Sql Qt6::OpenGLWidgets Qt6::Qml Qt6::Charts Qt6::Svg ${EXIF_LIB} ${FITS_LIB} ${RAW_LIB} ${WCS_LIB} ${LCMS2_LIB} XISF)
 if(APPLE)
     target_link_libraries(tenmon PRIVATE Qt6::DBus "-framework CoreFoundation")
 elseif(UNIX)

README

@@ -2,7 +2,7 @@ FITS/XISF image viewer with multithreaded image loading
 
 To get all dependencies install these packages
 
-    sudo apt install qt6-base-dev qt6-declarative-dev libqt6opengl6-dev libraw-dev libexif-dev libcfitsio-dev wcslib-dev cmake libzstd-dev libqt6sql6-sqlite
+    sudo apt install qt6-base-dev qt6-declarative-dev qt6-charts-dev libqt6opengl6-dev libraw-dev libexif-dev libcfitsio-dev wcslib-dev cmake libzstd-dev libqt6sql6-sqlite
 
 on OpenSUSE
 
@@ -26,6 +26,10 @@ Then to build run standard cmake sequence
     cmake --build build
     ./build/tenmon
 
+To install it to system run this command as root
+
+    cmake --install build
+
 For working plate solving you must have compiled and installed StellarSolver https://github.com/rlancaste/stellarsolver
 It is important that you compile StellarSolver with Qt6. By default it use Qt5 but when linked with Qt6 program it will
 crash.

space.nouspiro.tenmon.metainfo.xml

@@ -47,6 +47,7 @@
     </keywords>
     <url type="homepage">https://nouspiro.space/?page_id=206</url>
     <url type="bugtracker">https://github.com/flathub/space.nouspiro.tenmon/issues</url>
+    <url type="vcs-browser">https://gitea.nouspiro.space/nou/tenmon</url>
     <screenshots>
         <screenshot type="default">
             <caption>Main window with image</caption>
@@ -59,6 +60,14 @@
     </screenshots>
     <content_rating type="oars-1.1"/>
     <releases>
+    <release version="20260217" date="2026-02-17">
+      <description>
+        <ul>
+          <li>Fix potentional crash</li>
+          <li>Enable sorting of FITS info</li>
+        </ul>
+      </description>
+    </release>
     <release version="20251101" date="2025-11-01">
       <description>
         <ul>

src/database.cpp

@@ -307,6 +307,11 @@ QVector<SkyObject> Database::getObjects(double minRa, double maxRa, double minDe
     return objects;
 }
 
+const QSqlDatabase &Database::db() const
+{
+    return database;
+}
+
 bool Database::indexDir2(const QDir &dir, QProgressDialog *progress, QStringList &scannedDirs)
 {
     if(scannedDirs.contains(dir.canonicalPath()))return true;

src/database.h

@@ -42,6 +42,7 @@ public:
     void reindex(QProgressDialog *progress);
     QStringList getFitsKeywords();
     QVector<SkyObject> getObjects(double minRa, double maxRa, double minDec, double maxDec);
+    const QSqlDatabase& db() const;
 protected:
     bool indexDir2(const QDir &dir, QProgressDialog *progress, QStringList &scannedDirs);
     bool indexFile(const QFileInfo &file);

src/databaseview.cpp

@@ -157,32 +157,67 @@ void FITSFileModel::filesUnmarked(const QModelIndexList &indexes)
     }
 }
 
+void FITSFileModel::load()
+{
+    if(!m_loaded)
+    {
+        m_loaded = true;
+        prepareQuery();
+    }
+}
+
 void FITSFileModel::prepareQuery()
 {
+    if(!m_loaded)return;
+
     QString cols;
     QString join;
     QStringList where;
     QString sql = m_columns.size() ? "SELECT f.file," : "SELECT f.file";
+    QVariantList bindValues;
+    QVariantList bindValuesJoin;
     for(int i=0; i<m_value.size(); i++)
     {
         if(m_key[i] == "file")
-            where.append(QString(" f.file LIKE '%1' ").arg(m_value[i]));
+        {
+            where.append(" f.file LIKE ? ");
+            bindValues.append(m_value[i]);
+        }
         else if(m_key[i] == "RA pos")
-            where.append(QString(" %1 BETWEEN f.minRa AND f.maxRa ").arg(RA(m_value[i])));
+        {
+            where.append(" ? BETWEEN f.minRa AND f.maxRa ");
+            bindValues.append(RA(m_value[i]));
+        }
         else if(m_key[i] == "DEC pos")
-            where.append(QString(" %1 BETWEEN f.minDec AND f.maxDec ").arg(DEC(m_value[i])));
+        {
+            where.append(" ? BETWEEN f.minDec AND f.maxDec ");
+            bindValues.append(DEC(m_value[i]));
+        }
         else if(m_key[i] == "RA range")
-            where.append(QString(" crVal1 BETWEEN %1 AND %2 ").arg(RA(m_value[i])).arg(RA(m_limit[i])));
+        {
+            where.append(" crVal1 BETWEEN ? AND ? ");
+            bindValues.append(RA(m_value[i]));
+            bindValues.append(RA(m_limit[i]));
+        }
         else if(m_key[i] == "DEC range")
-            where.append(QString(" crVal2 BETWEEN %1 AND %2 ").arg(DEC(m_value[i])).arg(DEC(m_limit[i])));
+        {
+            where.append(" crVal2 BETWEEN ? AND ? ");
+            bindValues.append(DEC(m_value[i]));
+            bindValues.append(DEC(m_limit[i]));
+        }
         else
-            join += QString(" JOIN fits_headers AS s%1 ON f.id=s%1.id_file AND s%1.key='%2' AND s%1.value LIKE '%3'").arg(i).arg(m_key[i]).arg(m_value[i]);
+        {
+            join += QString(" JOIN fits_headers AS s%1 ON f.id=s%1.id_file AND s%1.key=? AND s%1.value LIKE ? ").arg(i);
+            bindValuesJoin.append(m_key[i]);
+            bindValuesJoin.append(m_value[i]);
+        }
     }
     int i=0;
     for(auto &column : m_columns)
     {
         cols += QString("GROUP_CONCAT(h%1.value) AS h%1_value,").arg(i);
-        join += QString(" LEFT JOIN fits_headers AS h%1 ON f.id=h%1.id_file AND h%1.key='%2'").arg(i).arg(column);
+        join += QString(" LEFT JOIN fits_headers AS h%1 ON f.id=h%1.id_file AND h%1.key=?").arg(i);
+        bindValuesJoin.append(column);
         i++;
     }
     cols.chop(1);
@@ -191,7 +226,18 @@ void FITSFileModel::prepareQuery()
     sql += join;
     if(!where.isEmpty())sql += " WHERE " + where.join("AND");
     sql += " GROUP BY f.id" + m_sort;
-    setQuery(sql);
+
+    QSqlQuery query(m_database->db());
+    query.prepare(sql);
+    for(auto &val : bindValuesJoin)
+        query.addBindValue(val);
+    for(auto &val : bindValues)
+        query.addBindValue(val);
+
+    if(!query.exec())
+        qWarning() << "Failed to exectute query" << query.lastQuery() << bindValuesJoin << bindValues;
+    setQuery(std::move(query));
+
     setHeaderData(0, Qt::Horizontal, tr("File name"));
     i = 1;
     for(auto &column : m_columns)
@@ -392,6 +438,7 @@ bool DataBaseView::exportCSV(const QString &path)
     if(!csv.open(QIODevice::WriteOnly | QIODevice::Text))
         return false;
 
+    m_model->load();
     QSqlQuery sql(m_model->query().lastQuery());
     int colCount = m_model->columnCount();
     QStringList header;
@@ -420,3 +467,8 @@ bool DataBaseView::exportCSV(const QString &path)
     }
     return true;
 }
+
+void DataBaseView::visible(bool visible)
+{
+    if(visible)m_model->load();
+}

src/databaseview.h

@@ -30,6 +30,7 @@ class FITSFileModel : public QSqlQueryModel
     QStringList m_limit;
     QSet<QString> m_markedFiles;
     Database *m_database;
+    bool m_loaded = false;
 public:
     explicit FITSFileModel(Database *database, QObject *parent = nullptr);
     void sort(int column, Qt::SortOrder order) override;
@@ -38,6 +39,7 @@ public:
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
     void filesMarked(const QModelIndexList &indexes);
     void filesUnmarked(const QModelIndexList &indexes);
+    void load();
 protected:
     void prepareQuery();
 };
@@ -74,6 +76,7 @@ public slots:
     void itemActivated(const QModelIndex &index);
     void applyFilter();
     bool exportCSV(const QString &path);
+    void visible(bool visible);
 signals:
     void loadFile(QString file);
 };

src/imageinfo.cpp

@@ -11,6 +11,8 @@ ImageInfo::ImageInfo(QWidget *parent) : QTreeWidget(parent)
     setIndentation(5);
     QSettings settings;
     header()->restoreState(settings.value("imageinfo/headerstate").toByteArray());
+    setSortingEnabled(true);
+    header()->setSortIndicatorClearable(true);
 }
 
 ImageInfo::~ImageInfo()

src/imageringlist.cpp

@@ -111,7 +111,7 @@ void Image::thumbnailLoadFinish(std::shared_ptr<RawImage> rawImage)
         emit thumbnailLoaded(this);
 }
 
-ImageRingList::ImageRingList(Database *database, const QStringList &nameFilter, QObject *parent) : QAbstractItemModel(parent)
+ImageRingList::ImageRingList(Database *database, const QStringList &nameFilter, QObject *parent) : QAbstractListModel(parent)
   , m_liveMode(false)
   , m_analyzeLevel(None)
   , m_database(database)
@@ -412,7 +412,7 @@ void ImageRingList::clearThumbnails()
         img->clearThumbnail();
 }
 
-QModelIndex ImageRingList::index(int row, int column, const QModelIndex &parent) const
+/*QModelIndex ImageRingList::index(int row, int column, const QModelIndex &parent) const
 {
     Q_UNUSED(parent);
     return createIndex(row, column, m_images.at(row).get());
@@ -422,7 +422,7 @@ QModelIndex ImageRingList::parent(const QModelIndex &child) const
 {
     Q_UNUSED(child);
     return QModelIndex();
-}
+}*/
 
 int ImageRingList::rowCount(const QModelIndex &parent) const
 {
@@ -432,31 +432,35 @@ int ImageRingList::rowCount(const QModelIndex &parent) const
         return 0;
 }
 
-int ImageRingList::columnCount(const QModelIndex &parent) const
+/*int ImageRingList::columnCount(const QModelIndex &parent) const
 {
     Q_UNUSED(parent);
     return 1;
-}
+}*/
 
 QVariant ImageRingList::data(const QModelIndex &index, int role) const
 {
-    switch(role)
+    if(index.isValid() && index.row() >= 0 && index.row() < m_images.size())
     {
-    case Qt::DisplayRole:
-    {
-        QFileInfo info(m_images.at(index.row())->name());
-        return info.fileName();
-    }
-    case Qt::FontRole:
-    {
-        bool marked = m_database->isMarked(m_images.at(index.row())->name());
-        QFont font;
-        font.setBold(marked);
-        return font;
-    }
-    default:
-        return QVariant();
+        switch(role)
+        {
+        case Qt::DisplayRole:
+        {
+            QFileInfo info(m_images.at(index.row())->name());
+            return info.fileName();
+        }
+        case Qt::FontRole:
+        {
+            bool marked = m_database->isMarked(m_images.at(index.row())->name());
+            QFont font;
+            font.setBold(marked);
+            return font;
+        }
+        default:
+            return QVariant();
+        }
     }
+    return QVariant();
 }
 
 QVariant ImageRingList::headerData(int section, Qt::Orientation orientation, int role) const

src/imageringlist.h

@@ -51,7 +51,7 @@ typedef std::shared_ptr<Image> ImagePtr;
 
 class Database;
 
-class ImageRingList : public QAbstractItemModel
+class ImageRingList : public QAbstractListModel
 {
     Q_OBJECT
     int m_width;
@@ -93,10 +93,10 @@ public:
     void updateMark();
     void clearThumbnails();
 
-    QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
-    QModelIndex parent(const QModelIndex &child) const override;
+    //QModelIndex index(int row, int column, const QModelIndex &parent = QModelIndex()) const override;
+    //QModelIndex parent(const QModelIndex &child) const override;
     int rowCount(const QModelIndex &parent = QModelIndex()) const override;
-    int columnCount(const QModelIndex &parent = QModelIndex()) const override;
+    //int columnCount(const QModelIndex &parent = QModelIndex()) const override;
     QVariant data(const QModelIndex &index, int role = Qt::DisplayRole) const override;
     QVariant headerData(int section, Qt::Orientation orientation, int role = Qt::DisplayRole) const override;
 public slots:

src/mainwindow.cpp

@@ -196,7 +196,12 @@ MainWindow::MainWindow(QWidget *parent) : QMainWindow(parent)
 #endif
     fileMenu->addAction(tr("Copy marked files"), Qt::Key_F5, this, &MainWindow::copyMarked);
     fileMenu->addAction(tr("Move marked files"), Qt::Key_F6, this, &MainWindow::moveMarked);
-    fileMenu->addAction(tr("Move marked files to trash"), QKeySequence::Delete, this, &MainWindow::deleteMarked);
+    QAction *deleteAction = fileMenu->addAction(tr("Move marked files to trash"), QKeySequence::Delete, this, &MainWindow::deleteMarked);
+#ifdef Q_OS_MACOS
+    deleteAction->setShortcuts(QList<QKeySequence>({Qt::Key_Backspace, QKeySequence::Delete}));
+#else
+    deleteAction->setShortcuts(QKeySequence::Delete);
+#endif
     fileMenu->addSeparator();
     fileMenu->addAction(tr("Index directory"), this, static_cast<void (MainWindow::*)()>(&MainWindow::indexDir));
     fileMenu->addAction(tr("Reindex files"), this, &MainWindow::reindex);